common: remove \n on clog messages #13794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-clog-newlines
branch
from
2f8040a
to
70fb3ed
Compare
badone
requested changes
Mar 5, 2017
src/mds/Server.cc
Outdated
| @@ -2345,7 +2345,7 @@ CInode* Server::prepare_new_inode(MDRequestRef& mdr, CDir *dir, inodeno_t useino | |||
| dout(0) << "WARNING: client specified " << useino << " and i allocated " << in->inode.ino << dendl; | |||
| mds->clog->error() << mdr->client_request->get_source() | |||
| << " specified ino " << useino | |||
| << " but mds." << mds->get_nodeid() << " allocated " << in->inode.ino << "\n"; | |||
| << " but mds." << mds->get_nodeid() << " allocated " << in->inode.ino << ""; | |||
There was a problem hiding this comment.
Can we get rid of ' << ""' here? What purpose does it serve?
Confirmed these aren't needed, and are inconsistently included. Remove them where they do appear. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-clog-newlines
branch
from
70fb3ed
to
693132e
Compare
badone
approved these changes
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirmed these aren't needed, and are inconsistently included.
Remove them where they do appear.
Signed-off-by: Sage Weil sage@redhat.com